D20930: Update WireGuard to match NetworkManager 1.16 interface

[Bruce Anderson]

andersonbruce marked an inline comment as done.
andersonbruce added a comment.


  In D20930#464412 <https://phabricator.kde.org/D20930#464412>, @jgrulich wrote:
  
  > In D20930#464403 <https://phabricator.kde.org/D20930#464403>, @andersonbruce wrote:
  >
  > > In D20930#464387 <https://phabricator.kde.org/D20930#464387>, @jgrulich wrote:
  > >
  > > > In D20930#464384 <https://phabricator.kde.org/D20930#464384>, @jgrulich wrote:
  > > >
  > > > > In D20930#464377 <https://phabricator.kde.org/D20930#464377>, @andersonbruce wrote:
  > > > >
  > > > > > Updated SecretAgent class to always try to get the secrets from kwallet even if the 'allow-interaction' flag is set. The keys WireGuard uses are 43 random characters long and we don't expect the user to enter these manually when trying to make a connection. If data is not available in kwallet then trying to make a connection will fail. Also updated the configuration screens to not allow a configuration with "AlwaysAsk" flags on either key.
  > > > >
  > > > >
  > > > > You can disable "AlwaysAsk" option with PasswordField::setPasswordNotRequiredEnabled(false).
  > > >
  > > >
  > > > Sorry, that's not it, I added a new option to do that, you can now use PasswordField::setPasswordNotSavedEnabled(false).
  > >
  > >
  > > Great!  Should I make the change in this review? If so, what is the correct procedure (with git, arc, ...) to merge that change into this review?
  >
  >
  > Should be enough just to merge current master into your branch I guess.
  
  
  Isn't  'arc diff' going to try to include the differences between the master I originally checked out and the merged current master as changes in the WireGuard review then?  Sorry if these are stupid questions, I'm not a git expert and I just don't want to mess things up.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190513/e7c1a0e2/attachment-0001.html>