D21111: Added new option to use GlobalProtect with openconnect

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> CMakeLists.txt:62
>          install(FILES plasmanetworkmanagement_openconnect_juniperui.desktop  DESTINATION ${KDE_INSTALL_KSERVICES5DIR})
> +        install(FILES plasmanetworkmanagement_openconnect_globalprotect.desktop  DESTINATION ${KDE_INSTALL_KSERVICES5DIR})
>      else()

It should be named plasmanetworkmanagement_openconnect_globalprotectui.desktop for consistency with the rest of openconnect types.

> openconnectwidget.cpp:190
> +    }
> +    else if (dataMap[NM_OPENCONNECT_KEY_PROTOCOL] == QLatin1String("nc")) {
> +        cmbProtocolIndex = 1;

Coding style, the "else if" should be on the same line as the "}" bracket.

> openconnectwidget.cpp:193
> +    }
> +    else {
> +        cmbProtocolIndex = 2; // paloAlto/GlobalProtect (gp)

Same here.

> plasmanetworkmanagement_openconnect_globalprotect.desktop:17
> +X-KDE-PluginInfo-EnabledByDefault=false
> +Name=Palo Alto / Global Protect VPN (openconnect)
> +Comment=Compatible with Palo Alto Global Protect VPN

I would use what NM use:
PAN GlobalProtect (openconnect)

> plasmanetworkmanagement_openconnect_globalprotect.desktop:18
> +Name=Palo Alto / Global Protect VPN (openconnect)
> +Comment=Compatible with Palo Alto Global Protect VPN

Same here:
Compatible with PAN GlobalProtect SSL VPN

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D21111

To: avaldes, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190510/fc828e79/attachment-0001.html>