D21088: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI
Nathaniel Graham
noreply at phabricator.kde.org
Wed May 8 21:40:02 BST 2019
ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
- Port to QQC2+Kirigami FormLayout style
- Use standard import names
- Adjust some strings to sound a bit more natural
- Use Kirigami ActionTextField so that the text field can have a clear button
- Fix a bug preventing the text field from being disabled once enabled
TEST PLAN
- All features still work
- Settings are saved and loaded correctly
On the desktop: F6815666: On desktop.png <https://phabricator.kde.org/F6815666>
In a horizontal panel: F6815665: In a horizontal panel.png <https://phabricator.kde.org/F6815665>
In a vertical panel: F6815667: In a vertical panel.png <https://phabricator.kde.org/F6815667>
REPOSITORY
R114 Plasma Addons
BRANCH
quicklaunch-modernize-settings-window (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D21088
AFFECTED FILES
applets/quicklaunch/package/contents/ui/ConfigGeneral.qml
To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190508/719e7c47/attachment.html>
More information about the Plasma-devel
mailing list