D21074: [System Monitor] Port settings window to QQC2+Kirigami FormLayout and modernize UI

Filip Fila noreply at phabricator.kde.org
Wed May 8 21:29:36 BST 2019


filipf added inline comments.

INLINE COMMENTS

> ConfigGeneral.qml:113
> +    Kirigami.FormLayout {
> +        id: formLayout
> +

We should do `anchors.left: parent.left` and `anchors.right: parent.right` here so the layout is horizontally centered.

> ConfigGeneral.qml:121
> +
> +            Kirigami.FormData.label: i18n("Update Interval:")
> +            decimals: 1

Should be `"Update interval:"` afaik

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21074

To: ngraham, #vdg, #plasma
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190508/8330d165/attachment-0001.html>


More information about the Plasma-devel mailing list