D19796: [Device Notifier] Restore Solid notification messages

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> DeviceItem.qml:50
>  
> -    readonly property bool hasMessage: statusSource.lastUdi == udi && statusSource.data[statusSource.last] ? true : false
> -    readonly property var message: hasMessage ? statusSource.data[statusSource.last] || ({}) : ({})
> +    readonly property bool hasMessage: statusSource.trigger && statusSource.lastMessages[udi] ? true : false
> +    readonly property var message: hasMessage ? statusSource.lastMessages[udi] : ({})

do we need `? true : false` i think no?

> devicenotifier.qml:226
> +                } else {
> +                    delete(lastMessages[udi])
>                  }

clearMessage(udi)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19796

To: thsurrel, #plasma, broulik, bruns
Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190507/42665fa0/attachment.html>