D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed

[Kai Uwe Broulik]

broulik added a comment.


  Looks lovely!

INLINE COMMENTS

> ActionButton.qml:69
> +    Rectangle {
> +        id: highlightCircle
> +        anchors.centerIn: iconCircle

This item isn't referenced, so it doesn't need to have an id

> ActionButton.qml:71
> +        anchors.centerIn: iconCircle
> +        width: mouseArea.containsPress ? iconCircle.width : undefined
> +        height: mouseArea.containsPress ? iconCircle.height : undefined

Are you sure you can assign `undefined` to this?

(Good catch using `containsPress` instead of `pressed!` to match proper button behavior! :)

> ActionButton.qml:76
> +        opacity: 0.15
> +        Behavior on width {
> +                PropertyAnimation {

Can't you just `scale` the item instead of animating its width and height since the item is always "square" anyway

REPOSITORY
  R120 Plasma Workspace

BRANCH
  add-pressed-state-to-action-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21062

To: filipf, #vdg, #plasma, ngraham, davidedmundson
Cc: broulik, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190507/c36be8bb/attachment.html>