D21056: [System Monitor] [Timer] Port settings window to QQC2+Kirigami FormLayout and modernize UI

Nathaniel Graham noreply at phabricator.kde.org
Mon May 6 22:17:54 BST 2019


ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  - Port to QQC2+Kirigami FormLayout style, except for the SpinBox which cannot handle decimal values well in the QQC2 version
  - Use standard import names
  - Adjust some strings to sound a bit more natural

TEST PLAN
  - All features still work
  - Settings loaded correctly when the window appears and saved correctly
  
  F6813206: Monitor.png <https://phabricator.kde.org/F6813206>
  F6813205: Colors, automatic.png <https://phabricator.kde.org/F6813205>
  F6813204: Colors, Manual.png <https://phabricator.kde.org/F6813204>

REPOSITORY
  R114 Plasma Addons

BRANCH
  monitor-modernize-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21056

AFFECTED FILES
  applets/systemloadviewer/package/contents/ui/ColorSettings.qml
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190506/f1ddc354/attachment-0001.html>


More information about the Plasma-devel mailing list