D20265: Introduce libnotificationmanager

[Eike Hein]

hein added inline comments.

INLINE COMMENTS

> notificationgroupingproxymodel.cpp:38
> +
> +bool NotificationGroupingProxyModel::appsMatch(const QModelIndex &a, const QModelIndex &b) const
> +{

Careful there - these will match when both are empty, which is why the libtm version tests for that. Are you sure this data cannot ever be missing?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20265

To: broulik, #plasma
Cc: hein, mart, nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190505/c95407ab/attachment.html>