D21013: [PanelView] remove outdated hack to support mask without compositing

Michail Vourlakos noreply at phabricator.kde.org
Sat May 4 15:36:09 BST 2019


mvourlakos added a comment.


  In D21013#460765 <https://phabricator.kde.org/D21013#460765>, @kossebau wrote:
  
  > Eek, sorry for breaking things. Will have some thoughts about it.
  >  Though, hm,  `item->window()->mask().isNull()` is really a random heuristic asking to break sooner or later, given we have seen all kind of panel/dock styles by the time :)  Well, actually it was already broken before given that the Oxygen Theme is non-simple-rect and the missing proper mask was a bug.
  >  This really needs a proper solution with well defined concepts.
  
  
  yep, I agree...
  
  This is why I left the assumption only in one place and I didnt merge more commits elsewhere until the situation
  has a more concrete approach.... e.g. https://phabricator.kde.org/D15814

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21013

To: kossebau, #plasma
Cc: davidedmundson, mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190504/edd85f4f/attachment.html>


More information about the Plasma-devel mailing list