D20973: [Kickoff] Use simpler code for separator color
Filip Fila
noreply at phabricator.kde.org
Fri May 3 00:34:34 BST 2019
filipf added a comment.
In D20973#459842 <https://phabricator.kde.org/D20973#459842>, @ngraham wrote:
> Yeah, much saner. Nice! I recall copy-pasting this code from elsewhere so you might wanna have look-see to check whether there are other uses of this that can be simplified as well.
I think it was taken from Kirigami's separator. I probably shouldn't mess with its color since it might be fine tuned to match the borders of other QQC2 elements etc. or might also be fine tuned to match Breeze menu border colors.
From a practical POV not even Kvantum can make QML windows transparent so there wouldn't be the same problem with the Kirigami separator as here.
REPOSITORY
R119 Plasma Desktop
BRANCH
kickoff-simpler-color-code (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D20973
To: filipf, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190502/78686d11/attachment-0001.html>
More information about the Plasma-devel
mailing list