D20265: Introduce libnotificationmanager

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> jobsmodel.cpp:215
> +{
> +    if (!idx.isValid() || idx.row() >= d->m_jobViews.count()) {
> +        return;

https://doc.qt.io/qt-5/qabstractitemmodel.html#checkIndex

> jobsmodel_p.cpp:358
> +
> +    for (int i = 0; i < m_jobViews.count(); ++i) {
> +        Job *job = m_jobViews.at(i);

you're not filtering the jobs based on the desktopEntry

every app gets notified about anyones percentage?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20265

To: broulik, #plasma
Cc: mart, nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190502/25b51235/attachment-0001.html>