D14147: Port from GConf to GSettings
David Rosca
noreply at phabricator.kde.org
Sun Mar 31 09:34:10 BST 2019
drosca added inline comments.
INLINE COMMENTS
> pino wrote in gsettingsitem.cpp:42
> should this be qCCritical, to hard-fail in case other types of keys are used (instead of silently doing nothing)?
qCritical is not hard-fail, that would be qFatal, but don't really see a reason to abort here in any case.
It should be at least qWarning though, as qDebug is usually disabled by default.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D14147
To: nicolasfella, drosca, davidedmundson
Cc: pino, lbeltrame, evpokp, rikmills, broulik, asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190331/7d31244f/attachment.html>
More information about the Plasma-devel
mailing list