D14147: Port from GConf to GSettings

David Rosca noreply at phabricator.kde.org
Sun Mar 31 09:12:58 BST 2019


drosca added inline comments.

INLINE COMMENTS

> gsettingsitem.cpp:58
> +    GVariant *oldValue = g_settings_get_value(m_settings, key.toLatin1().data());
> +    GVariant *newValue;
> +

`= nullptr`, otherwise you have a crash if the following switch falls to default case.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D14147

To: nicolasfella, drosca, davidedmundson
Cc: lbeltrame, evpokp, rikmills, broulik, asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190331/dad9b2f0/attachment-0001.html>


More information about the Plasma-devel mailing list