D19687: Allow single images to be excluded from the slideshow

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.

INLINE COMMENTS

> config.qml:41
>      property int cfg_SlideInterval: 0
> +    property var cfg_UncheckedSlides: ""
>  

default should be []

> slidemodel.cpp:57
> +   QHash<int, QByteArray> roleNames = BackgroundListModel::roleNames();
> +   roleNames.insert(ToggleRole, "toggled");
> +   return roleNames;

toggled is a misleading term as toggling in either direction is toggled. You want to represent state.
The typical QAction term is "checked"

REPOSITORY
  R120 Plasma Workspace

BRANCH
  toggleSlides

REVISION DETAIL
  https://phabricator.kde.org/D19687

To: davidre, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, filipf, abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190330/2aff0b90/attachment-0001.html>