D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Krešimir Čohar]

rooty added a comment.


  In D19822#439167 <https://phabricator.kde.org/D19822#439167>, @hein wrote:
  
  > I'm not a fan of the checkbox, I think it's a little gratuitous. If you add a small feature and need to immediately add a checkbox to disable it, it's rather a red flag to me. It means either the feature or the checkbox should probably go.
  
  
  This is a specious argument. It's like the single click vs double click debate. Either the single clicking goes or the option to disable it does - neither a particularly delightful option. Keep both and you get to avoid this pitfall.
  
  In essence, I believe that whether or not you can disable this feature should have no bearing on whether it should be included. And as far as dropping the option to disable it goes, why? It just detracts from more versatility.
  
  I like this change I'd just prefer it if you could post screenshots in the test plan section?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  taskmanager-mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, filipf
Cc: rooty, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190327/5ec00bd6/attachment-0001.html>