D19852: Change default Klipper behavior to accept images

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> kdautovic wrote in klipper.cpp:744
> But bIgnoreImages is used later in the code, when determining whether to save images to history or not. Is it really necessary here? If it's added here then we're back to square one because copying screenshots to clipboard won't work with the default behavior of Klipper.

We want:

1. if ignore images is false and it's from spectacle - we load the image in the cache and the history
2. if ignore images is false and it's not from spectacle - we load the image in the cache and the history
3. if ignoreImages is true and it's from spectacle, we load the image, but don't keep in history
4. if ignoreImages is true and it's not from spectacle we throw it away.

I think this patch is going to break case 2 as we now return early.

But you're right that my comment was wrong, I meant.

  if (m_ignoreImage && !data->
      return;

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19852

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190326/3da050ce/attachment.html>