D18579: Rework Sensor Browser

[Vlad Zagorodniy]

zzag added a comment.


  > Fix code style
  
  In general, the coding style situation in KSysGuard is a bit sad. I personally can't trace any distinct coding style, it's basically a mix of every potential coding style.
  
  We should probably run clang-format and clang-tidy over it some time later.

INLINE COMMENTS

> SensorBrowser.cpp:57
>  {
> +    qDebug() << "Testing!";
>  #ifdef SENSOR_MODEL_DO_TEST

Please delete it.

> SensorBrowser.cpp:172
>      QStringList childSensors;
>      QList<int> children = mTreeMap.value(parentId);
> +    for(const auto& child: qAsConst(children)) {

Please make it const instead. It would be nice to use qAsConst as less as possible.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D18579

To: tcanabrava
Cc: zzag, argonel, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190325/bcd0a424/attachment.html>