D19977: Prevent context drawer from disappearing
Dimitris Kardarakos
noreply at phabricator.kde.org
Fri Mar 22 15:35:42 GMT 2019
dkardarakos created this revision.
dkardarakos added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.
REVISION SUMMARY
Currently, on plasma mobile, if you navigate from a page that contains contextual actions to a page without contextual actions and back, context drawer disappears. Looking for contextual actions in pageStack.layers.currentItem only when pageStack.layers.depth > 1, then checking pageStack.currentItem and finally, checking pageStack.lastVisibleItem, we ensure that we look for contextual actions in the most relevant page.
TEST PLAN
On mobile, navigate from a page that contains contextual actions to a page without contextual actions and back.
Before patching:
Context drawer disappears
After patching:
Context drawer is still visible
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D19977
AFFECTED FILES
src/controls/ContextDrawer.qml
To: dkardarakos, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190322/df162210/attachment.html>
More information about the Plasma-devel
mailing list