D19963: Avoid serializing base64 encoded favicon data twice

Stefan BrĂ¼ns noreply at phabricator.kde.org
Fri Mar 22 02:38:57 GMT 2019


bruns created this revision.
bruns added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The URL is ignored in case the image data is available. Avoid pushing
  it twice via DBus.

TEST PLAN
  1. start dbus-monitor
  2. type some string in krunner
  
  before: dict entries contain both favIconData and favIconUrl, with
  
    identical data
  
  after:  only favIconData is part of the dict
  
  Favicons are still shown in the krunner results

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  favicondata

REVISION DETAIL
  https://phabricator.kde.org/D19963

AFFECTED FILES
  extension/extension.js

To: bruns, #plasma, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190322/0244e020/attachment.html>


More information about the Plasma-devel mailing list