D19959: Fixed issue causing changed signal to be called with false argument

Tigran Gabrielyan noreply at phabricator.kde.org
Thu Mar 21 23:48:04 GMT 2019


tigrang created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tigrang requested review of this revision.

REVISION SUMMARY
  AdvanceConfig::changed signal is called with changed=false arguement when QGroupBox::clicked is called with checked=false causing the Apply button to remain disabled.
  
        
  
  BUG: 403366

TEST PLAN
  1. Open SDDM settings
  2. Enable auto-login, save and close.
  3. Open SDDM settings again
  4. Uncheck auto-login
  
  Apply button should now be enabled.
  Same steps for Relogin after quit checkbox.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19959

AFFECTED FILES
  src/advanceconfig.cpp

To: tigrang
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190321/89e5bafc/attachment.html>


More information about the Plasma-devel mailing list