D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row
Nathaniel Graham
noreply at phabricator.kde.org
Mon Mar 18 23:56:54 GMT 2019
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
The spacing change is clearly correct. As for the width change, we should match the exact calculation used for the other combobox we're trying to match, which is `width: theme.mSize(theme.defaultFont).width * 24`. Otherwise they'll drift out of sync when `formAlignment` changes or the next time `Kirigami.Units.largeSpacing` is modified.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D19873
To: filipf, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190318/b8353472/attachment-0001.html>
More information about the Plasma-devel
mailing list