D19802: [comic] Modernize configuration windows

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> filipf wrote in configAdvanced.qml:55
> It's always the plural now, but I also realized we shouldn't be using singular if value is 1 because some Slavic languages use singular with 21, 31, etc.

Yep, even if the quantity will always be more than one, it should always use an `i18np()`. for just that reason. :)

> configGeneral.qml:112
> +    Layouts.RowLayout {
> +            Kirigami.FormData.label: i18nc("@label:spinbox", "Check for new comic strips every:")
> +

"comic strips" -> "comics"

> configGeneral.qml:121
> +        Controls.Label {
> +            text: i18ncp("@item:valuesuffix spacing to number + unit (minutes)", "min", "mins")
> +        }

"Mins" -> "Minutes" (etc)

> ngraham wrote in configGeneral.qml:97
> I'd recommend putting these in the FormLayout rather than using a RowLayout, since now the spinboxes aren't aligned anymore.

You could shorten this very long string by writing it as "Check for new plugins every:"

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19802

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190318/102a7cbd/attachment-0001.html>