D19851: [kirigami] make it compile without foreach

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Mar 18 14:32:08 GMT 2019


apol added inline comments.

INLINE COMMENTS

> kirigamiplugin.cpp:48
>  {
> -    foreach (const QString &style, m_stylesFallbackChain) {
> +    for (const QString &style : qAsConst(m_stylesFallbackChain)) {
>          const QString candidate = QStringLiteral("styles/") + style + QLatin1Char('/') + fileName;

qAsConst isn't necessary because the method is already const.
Is it just for readability?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19851

To: mlaurent, dfaure
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190318/24503d22/attachment.html>


More information about the Plasma-devel mailing list