D19838: [powerdevil] Touch up messages/prompts
Nathaniel Graham
noreply at phabricator.kde.org
Mon Mar 18 08:59:59 GMT 2019
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Awesome. Go ahead and make your proposed change if you'd like, then shipit!
INLINE COMMENTS
> rooty wrote in powerdevilcore.cpp:367
> "or because the action is not supported", "This is due to the action not being supported" sounds too elaborate for my taste and I'd rather have a disconnected clause here
That was actually going to be my first suggestion. :) Go ahead and do that if you think it sounds better.
> rooty wrote in powerdevilcore.cpp:541
> I thought about that, then realized that the heading says "Mouse" (Mouse Battery Low) "Keyboard" etc. so it seems redundant too (to repeat it in the body text)
Ah, you're right!
REPOSITORY
R122 Powerdevil
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D19838
To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190318/8c0a4f03/attachment.html>
More information about the Plasma-devel
mailing list