D19502: Add a SearchField and PasswordField component

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ognarb wrote in SearchField.qml:44
> Are you sure? It would mean that Kirigami should then depends on ki18n. And them Kirigami wouldn't be a Tier 1 KDE framework anymore.
> 
> @mart should I move this in the example code or it is fine with a translation domain?

no, it can't depend from ki18n.
here we can onlt use qsTr

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19502

To: ognarb, #kirigami, ngraham, mart
Cc: broulik, apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190317/2d33866d/attachment.html>