D19826: kns: Show subcategories for things that have one

[Dan Leinir Turthra Jensen]

leinir requested changes to this revision.
leinir added a comment.


  The rest looks nice and solid :)

INLINE COMMENTS

> KNSBackend.cpp:161
> +    if (cats.count() > 1) {
> +        m_categories += cats;
> +        for(const auto &cat: cats) {

Don't think we need this, already creating the categories as Category instances just below, and we set the category on the Resource instance when we create that in ::resourceForEntry... With it we'd end up duplicating those categories in the list of categories for all resources, from what i can tell this line just isn't needed :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19826

To: apol, #discover_software_store, leinir
Cc: leinir, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190317/3dd2aaa5/attachment.html>