D19802: [comic] Modernize configuration windows
Nathaniel Graham
noreply at phabricator.kde.org
Sat Mar 16 17:24:03 GMT 2019
ngraham added a subscriber: mart.
ngraham added a comment.
In D19802#432171 <https://phabricator.kde.org/D19802#432171>, @filipf wrote:
> Definitely some silly mistakes in there, thanks for showing me how to do it right!
>
> As for the looks, I'm struggling with liking the placement of the headings when Kirigami.FormData.label is used, hence the row layouts. Case in point:
>
> F6696611: Screenshot_20190316_101200.png <https://phabricator.kde.org/F6696611>
>
> The gaps in vertical spaces the headings leave just doesn't look good to me.
Me neither.
But that's "as designed" and we shouldn't work around the design; we should fix it if we think it's ugly.
Paging Dr. @mart :)
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D19802
To: filipf, rooty, ngraham, #vdg, #plasma
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190316/c969d2db/attachment.html>
More information about the Plasma-devel
mailing list