D19803: [Tabs Runner] Check DBus reply signature

Kai Uwe Broulik noreply at phabricator.kde.org
Sat Mar 16 10:48:54 GMT 2019


broulik created this revision.
broulik added reviewers: Plasma, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Qt tends to crash when trying to `qdbus_cast` to a wrong type

TEST PLAN
  Similar check was done in mpris for broken players: https://cgit.kde.org/plasma-workspace.git/tree/dataengines/mpris2/playercontainer.cpp#n193
  
  Compiles, tabs still show up, didn't actually get the crash but Aleix told me about, don't know how that could actually happen...

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D19803

AFFECTED FILES
  tabsrunner/tabsrunner.cpp

To: broulik, #plasma, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190316/8c1d1602/attachment.html>


More information about the Plasma-devel mailing list