D19687: Allow single images to be excluded from the slideshow
Nathaniel Graham
noreply at phabricator.kde.org
Sat Mar 16 09:47:55 GMT 2019
ngraham accepted this revision as: VDG.
ngraham added a comment.
UI looks good now. I've done some code review below:
INLINE COMMENTS
> image.cpp:623
> m_slideshowBackgrounds = paths;
> + Q_FOREACH(const QString &slide, m_uncheckedSlides) {
> + m_slideshowBackgrounds.removeAll(QUrl(slide).path());
Don't use `Q_FOREACH` in new code. See https://www.kdab.com/goodbye-q_foreach/
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D19687
To: davidre, #plasma, #vdg, ngraham
Cc: filipf, abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190316/efaf14d4/attachment.html>
More information about the Plasma-devel
mailing list