D19790: Improve the look of the GTK Application Style KCM UI

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Mar 15 18:44:48 GMT 2019


apol added inline comments.

INLINE COMMENTS

> kde-gtk-config.desktop:1
>  [Desktop Entry]
> +Exec=kcmshell5 kde-gtk-config

All this not saying they're right or wrong but unrelated to the change at stake.

> kde-gtk-config.desktop:59
> +
> +X-KDE-Keywords=gnome,gtk,style,styles,look,widget,icons,toolbars,text,highlight,apps,theme,menu
>  X-KDE-Keywords[ca]=gnome,estil,gtk

How is "text" or "highlight" relevant to this?

> gtkconfigkcmodule.cpp:65
>      Q_UNUSED(args);
> -    KAboutData *acercade = new KAboutData("cgc", i18n("KDE GTK Config"), PROJECT_VERSION,
> -                    i18n("Configure your GTK Applications"),
> -                    KAboutLicense::LGPL_V3,
> -                    i18n("Copyright 2011 José Antonio Sánchez Reynaga"));
> +    KAboutData *acercade = new KAboutData("cgc", i18n("GTK Application Style"), PROJECT_VERSION,
> +                    QString(), KAboutLicense::LGPL_V3, i18n("Copyright 2011 José Antonio Sánchez Reynaga"));

Unrelated.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D19790

To: GB_2, #plasma, #vdg
Cc: apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190315/a9a803cc/attachment-0001.html>


More information about the Plasma-devel mailing list