D19752: [Splash KCM] Use InlineMessage for testing error

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Mar 14 09:40:49 GMT 2019


broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When testing a splash screen fails, a message box appears. This changes it to an `InlineLabel` and also makes process handling asynchronous to not block the settings dialog process and instead disables the controls within.

TEST PLAN
  Made a ksplash theme that just froze the splash process, killed it, got this error.
  F6690792: Screenshot_20190314_103534.png <https://phabricator.kde.org/F6690792>

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19752

AFFECTED FILES
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h
  kcms/ksplash/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190314/73656e03/attachment.html>


More information about the Plasma-devel mailing list