D19744: [taskmanager] Fix desktop file mapping for some apps

Nicolas Fella noreply at phabricator.kde.org
Thu Mar 14 01:32:38 GMT 2019


nicolasfella created this revision.
nicolasfella added reviewers: Plasma, hein, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Some apps (e.g. Nautilus) have more complex commands in their desktop file's Exec line (e.g. 'nautilus --new-window'). This breaks the cmd to desktop path mapping because =~ checks 
  for equality, but 'nautilus' isn't equal to 'nautilus --new-window'. Use ~~ instead which checks whether one string is contained in another 
  (https://techbase.kde.org/Development/Tutorials/Services/Traders#String_Matching_Operators).
  
  The fault can be reproduced with:
  ktraderclient5 --servicetype Application --constraint "exist Exec and ('nautilus' =~ Exec)" returns no matches
  
  ktraderclient5 --servicetype Application --constraint "exist Exec and ('nautilus' ~~ Exec)" matches org.gnome.Nautilus
  
  Same applies to Gedit and probably countless other apps.
  
  As a result jumplist actions for Nautilus and Gedit are working in the taskmanager now

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixnautilus

REVISION DETAIL
  https://phabricator.kde.org/D19744

AFFECTED FILES
  libtaskmanager/tasktools.cpp

To: nicolasfella, #plasma, hein, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190314/65ee5dd8/attachment-0001.html>


More information about the Plasma-devel mailing list