D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> configGeneral.qml:23
>  
> -import QtQuick 2.0
> -import QtQuick.Controls 1.0 as QtControls
> -import QtQuick.Layouts 1.1
> +import QtQuick 2.12
> +import QtQuick.Controls 2.5 as QtControls

Is this actually necessary for anything in the diff? If not, I would recommend against changing it.

> configGeneral.qml:31
>      id: generalConfigPage
> +    anchors.horizontalCenter: parent.horizontalCenter
>  

Anchor left and right to the parent's left and right, or else if we ever decide to make the formlayout not horizontally centered, this layout won't get that change automatically.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19669

To: filipf, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190313/d3113501/attachment-0001.html>