D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

[Harald Sitter]

sitter requested changes to this revision.
sitter added a comment.
This revision now requires changes to proceed.


  XML broken.
  
  The KMessageWidget being inside the groupbox looks a bit weird to me. Don't we usually put the messages at the top of the KCM?

INLINE COMMENTS

> kcmsmserver.cpp:70
>  
> +    m_login1Manager = new OrgFreedesktopLogin1ManagerInterface(QStringLiteral("org.freedesktop.login1"),
> +                                                               QStringLiteral("/org/freedesktop/login1"),

possibly should be up in the member initializer list?

> kcmsmserver.h:48
> +
> +  OrgFreedesktopLogin1ManagerInterface *m_login1Manager;
> +

`= nullptr`

> org.freedesktop.login1.Manager.xml:13
> +      <arg type="s" direction="out" />
> +    </method>
> +</node>

interface end tag missing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19560

To: broulik, #plasma, #vdg, sitter
Cc: sitter, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190311/3be4a621/attachment.html>