D19670: [appmenu] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> ngraham wrote in configGeneral.qml:21
> Is going that far actually required by anything?

Probably not but I'm always checking Qt documentation and simply using the import they recommend. Because 5.16 will depend on Qt 5.12 it shouldn't be a problem, but I can leave things as they are.

> ngraham wrote in configGeneral.qml:28
> Why use a top level `Item`? Was there a problem with using the `FormLayout` as the top-level object?

I'm seeing this consistently, properties don't work at all if placed in Kirigami.FormLayout. In this case if put there you can click on the options but the Apply button will just stay shaded.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19670

To: filipf, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190311/c00f6257/attachment-0001.html>