D19596: color monochrome icons to tooltip colors

[Marco Martin]

mart added a comment.


  In D19596#426701 <https://phabricator.kde.org/D19596#426701>, @sitter wrote:
  
  > The sidepanel (which I guess is the mainview) gets the icon from InfoKcmModel::data from what I can tell. ::data and ::generateToolTipLine are the only places where I see ::icon get called. So what I am thinking is these changes:
  >
  > ::icon goes away in favor of
  >
  > `QString KcmTreeItem::iconName() { return m_kcm.icon() }`
  >
  > and
  >
  > `QString KcmCategoryItem::iconName() { return m_category.icon() }`
  >
  > and the model creates a regular unaltered QIcon
  >
  >   QVariant InfoKcmModel::data(const QModelIndex &index, int role) const
  >   {
  >   ...
  >       case Qt::DecorationRole:
  >           return QIcon::fromTheme(item->iconName());
  >   ...
  >   }
  >
  
  
  +1
  can give a try tomorrow

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D19596

To: mart, #plasma, sitter
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190307/a8e8a3b7/attachment.html>