D19595: use a TextMetrics for height

[Harald Sitter]

sitter added a comment.


  I think this is the wrong TextField for SDDM/kscreenlocker actually. They use PlasmaComponents 2, which judging by my printf debugging isn't loading that particular TextField.qml.
  
  TextFieldStyle.qml seems to be what's loaded there, however when applying the change there it doesn't fix the problem :/
  In fact, setting implicitHeight seems largely useless. When I manually add +30, the field is larger but upon entering anything it still resizes by one pixel.
  
  BTW for testing you can simply `qmlscene Main.qml` in plasma-workspace/sddm-theme. Also on !neon you'll want P340 <https://phabricator.kde.org/P340> for your `~/.config/fontconfig/fonts.conf` to make sure font order is as it should be for noto. Oh, also I think the symbols2 split only happened like a year or two ago, so particularly old systems will also need newer noto TTFs.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D19595

To: mart, #plasma
Cc: sitter, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190307/f1a704ff/attachment.html>