D19572: [kcolorschemeditor] Don't re-add existing tab

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This keeps it from unexpectedly changing tabs as you change any values.
  
  BUG: 393282
  FIXED-IN: 5.15.3

TEST PLAN
  I tried to look into why Qt does it but I couldn't figure out why it happens.
  
    tabWidget->currentIndex(); // is 3
    tabWidget->addTab(m_inactiveTab, i18n("Inactive")); // returns 3
    tabWidget->currentIndex(); // is suddenly 2?!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19572

AFFECTED FILES
  kcms/colors/editor/scmeditordialog.cpp

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190306/b05787d4/attachment.html>