D19214: [sddm-theme] Replace login button label with icon

Krešimir Čohar noreply at phabricator.kde.org
Sun Mar 3 23:41:58 GMT 2019


rooty added a comment.


  In D19214#424074 <https://phabricator.kde.org/D19214#424074>, @ngraham wrote:
  
  > Looks like https://bugs.kde.org/show_bug.cgi?id=399155 has revealed that the text field itself just isn't tall enough. Fixing that should fix both the bug mentioned above, as well as the hackaround to make the button shorter so they're the same height.
  >
  > Let's either fix the issue in the PlasmaComponents text field before we land this, or else see if we can port this to use the Kirigami `ActionTextField` instead, which should be the correct height.
  
  
  I don't know. The Kirigami field uses a different glow, so I'm not sure which one of these is the better solution.
  
  While I understand that this height bug should be fixed, using Kirigami actually reveals how tall the field gets 
  F6655104: image.png <https://phabricator.kde.org/F6655104>
  And it comes out looking big and boxy
  Should we switch to a smaller font size maybe?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190303/a7165337/attachment.html>


More information about the Plasma-devel mailing list