D22139: port to KOSRelease

[Aleix Pol Gonzalez]

apol added a comment.


  T

INLINE COMMENTS

> systeminformation.cpp:249
>  
>  QString SystemInformation::fetchOSReleaseInformation() const
>  {

How about removing the function and just using KOSRelease?

Or at least rename to `readOSPrettyName`

> systeminformationtest.cpp:85
>          QCOMPARE(info.operatingSystem(), "FreeBSD 1.0.0 x86_64");
> -        QEXPECT_FAIL("", "os release parser is garbage", Continue);
> -        QCOMPARE(info.lsbRelease(), "KDE SUSE User Edition 5.16");
> +        QCOMPARE(info.lsbRelease(), ""); // FIXME: should also be set, its used in the submitted report
>          QCOMPARE(info.compiledSources(), false);

Is it a problem with  the data/os-release file?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22139

To: sitter, #plasma
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190628/6a5598b6/attachment-0001.html>