D22141: rename lsbRelease to prettyName and set it from os-release as well

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  previously when lsb_release was not present or working we'd fall back
  to os-release, but then not track the pretty name leading to the report
  containing no Distribution value.
  the more aptly named info variable is now set by both lsb_release and
  os-release logic, ensuring that in both scenarios we have the distro
  recorded in the report.
  
  systeminformationtest now also checks that the pretty name is set when
  testing on os-release (without lsb_release)
  
  this also will allow us to eventually move to prefer os-release instead of
  calling the external lsb_release script.

TEST PLAN
  builds & passes

REPOSITORY
  R871 DrKonqi

BRANCH
  kosrelease-compat

REVISION DETAIL
  https://phabricator.kde.org/D22141

AFFECTED FILES
  src/bugzillaintegration/reportinterface.cpp
  src/systeminformation.cpp
  src/systeminformation.h
  src/tests/systeminformationtest.cpp

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190628/73f63e22/attachment.html>