D22053: [libtaskmanager] Track stacking order and window activation (on X11)

Pino Toscano noreply at phabricator.kde.org
Wed Jun 26 19:45:44 BST 2019


pino added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in xwindowtasksmodel.cpp:673-675
> That's double lookup in intensive called function, what about
> 
>   int idx = d->lastActivated.indexOf(window);
>   if (idx >= 0)
>        return d->lastActivated.at(idx);

@anthonyfieroni `d->lastActivated` is a QHash, so your suggestion does even build. OTOH, using iterators will do it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22053

To: hein, #plasma
Cc: pino, anthonyfieroni, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190626/f5f4bf25/attachment-0001.html>


More information about the Plasma-devel mailing list