D22088: [Notifications] Ignore excess spam

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When multiple identical notifications are sent in quick succession, discard the request and let it fail.
  Previously it would always replace the last notification if identical, now it discards the request and only does so if it happened within 1 second of the last notification to avoid discarding genuine identical notifications like when deleting two plasmoids of the same type.
  
  BUG: 409157
  FIXED-IN: 5.16.3

TEST PLAN
  - Called `notify-send foo bar` twice in quick succession: didn't get two dialogs
  - Waited a seconds inbetween, got two dialogs

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22088

AFFECTED FILES
  libnotificationmanager/server_p.cpp
  libnotificationmanager/server_p.h

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190625/d1e2469b/attachment-0001.html>