D22065: Introduce PluginManager

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> pluginmanager.cpp:39
> +
> +void PluginManager::init()
> +{

Never called

> pluginmanager.cpp:69
> +
> +bool PluginManager::setPluginLoaded(const QString &subsystem, bool loaded)
> +{

I'd change this to accept the an AbstractBrowserPlugin pointer instead of the subsystem and do the lookup in `bool PluginManager::loadPlugin(const QString &subsystem)` instead.

Or just expose a `PluginManager::pluginForSubsystem(subsystem)` method.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D22065

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190625/448bcc04/attachment.html>