D22084: Span wayland objects to lifespan of the QApplication
David Edmundson
noreply at phabricator.kde.org
Mon Jun 24 17:51:38 BST 2019
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
We must release all wayland objects before the QPA connection is closed.
We used to do this explicitly, but this still left an awkward code path
where we could still try to recreate a BlurManager if it's called after
the QApplication is closed.
Instead we can scope all the wayland objects to the QApplication. The
objects themselves were not leaked as public API so this is safe. Calls
after this will simply no-op.
This fixes crashes on tear down of plasma.
TEST PLAN
kquitapp5 plasmashell
REPOSITORY
R130 Frameworks integration plugin using KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22084
AFFECTED FILES
src/windowsystem/waylandintegration.cpp
src/windowsystem/waylandintegration.h
To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190624/ab5d3693/attachment.html>
More information about the Plasma-devel
mailing list