D22070: make scripted sleep no-op

Harald Sitter noreply at phabricator.kde.org
Mon Jun 24 11:59:43 BST 2019


sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this was implemented using a nested loop, which is simply not viable
  because nested looping may work on inconsistent object states and cause
  crashes all over the place. furthermore sleeping probably has no real use
  case as there isn't anything you could be sleeping for
  
  prevent any future problems by making the API method do nothing and instead
  print a warning about it being deprecated.
  
  should be removed when moving over to kf6

TEST PLAN
  prints warning when sleeping

REPOSITORY
  R120 Plasma Workspace

BRANCH
  no-sleep

REVISION DETAIL
  https://phabricator.kde.org/D22070

AFFECTED FILES
  shell/scripting/appinterface.cpp

To: sitter
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190624/ce20c5d3/attachment.html>


More information about the Plasma-devel mailing list