D22068: Send downloads when downloads plugin is loaded

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Jun 24 10:12:25 BST 2019


broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We call `sendDownloads()` immediately when connecting to the port which looks racy.
  Instead, have the plugin tell the extension to send all downloads once it is loaded and ready to accept input.
  Kept the old call for compat which shouldn't hurt...

TEST PLAN
  Started a download, reloaded the extension, reliably got a download created again

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D22068

AFFECTED FILES
  extension/extension.js
  host/downloadplugin.cpp
  host/downloadplugin.h

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190624/5c8c2bb5/attachment-0001.html>


More information about the Plasma-devel mailing list