D21998: Batch MPRIS DBus property changes

Fabian Vogt noreply at phabricator.kde.org
Sat Jun 22 14:59:24 BST 2019


fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  There should be a comment somewhere to explain what's happening and why.

INLINE COMMENTS

> mprisplugin.h:153
>  
> +    QTimer *m_propertyChangeSignalTimer;
> +    // interface - <property name, value>

Why a pointer?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21998

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190622/1cbb5450/attachment.html>


More information about the Plasma-devel mailing list