D21944: Show shortcut in menu item when specified

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> apol wrote in MenuItem.qml:103
> Use Layout.rightMargin on the shortcut object.
> https://doc.qt.io/qt-5/qml-qtquick-layouts-layout.html#rightMargin-attached-prop

I think the original approach to use an Item was correct, both because now it looks wrong, but also because using an Item makes the layout automatically RTL compatible, while setting the right padding property requires conditional handling for the reversed case.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D21944

To: astippich, mart, ngraham, apol
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190622/5999aebe/attachment-0001.html>