D21763: [kcms/ksmserver] Port to new kworkspace API

Kai Uwe Broulik noreply at phabricator.kde.org
Fri Jun 21 17:36:15 BST 2019


broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kcmsmserver.cpp:86
> +        auto sm = new SessionManagement(this);
> +        auto doShutdown=[sm]() {
> +            sm->requestReboot();

Coding style.

> kcmsmserver.cpp:88
> +            sm->requestReboot();
> +            delete sm;
> +        };

Is this safe, or should it do a `deleteLater()`?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21763

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190621/a898fefe/attachment.html>


More information about the Plasma-devel mailing list